[Bug 698] Dialer crashes just after receiving a call

[bugzilla-daemon at bugzilla.openmoko.org]

http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=698





------- Additional Comments From stephane at shimaore.net  2007-08-13 06:38 -------
Reproducible in 20070803091138.

More precisely gdb shows the following backtrace:

#0  0x40d7626c in strcmp() from /lib/libc.so.6
#1  0x00017e8c in ?? ()

in stock 20070803091138 rootfs.

More importantly, a disassemble of the code after the return address in
openmoko-dialer shows:

0x00017e8c   mov     r3, r0
0x00017e90   cmp     r3, #0  ; 0x0
0x00017e94   bne     0x17ea8
0x00017e98   ldr     r0, [r11, #-76]
0x00017e9c   bl      0xe2bc <moko_journal_entry_get_summary>

Therefor we are looking for a "strcmp" followed by a
"moko_journal_entry_get_summary" in the code for openmoko-dialer. The only
instance of moko_journal_entry_get_summary in the openmoko-dialer (OM 2007) is
on line 690 of dialer-window-history.c, and is preceded by a call to strcmp.

The only parameter that is non-static in the strcmp is "number", which was
previously returned by moko_journal_voice_info_get_distant_number().

I suggest the code 

  /* If the number is null, the number may have been stored in the summary*/
  if (strcmp (number, "NULL") == 0)
    number = moko_journal_entry_get_summary (j_entry);

be replaced by

  /* If the number is null, the number may have been stored in the summary*/
  if (number == NULL || strcmp (number, "NULL") == 0)
    number = moko_journal_entry_get_summary (j_entry);

(It's also possible the strcmp is not needed at all.)




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.