Openmoko Bug #1834: openmoko-dialer2 crashes when no dbus connection could be set (bad error init)

[Openmoko Public Trac]

#1834: openmoko-dialer2 crashes when no dbus connection could be set (bad error
init)
--------------------------+-------------------------------------------------
    Reporter:  LeRoutier  |        Owner:  julian_chu
        Type:  defect     |       Status:  new       
    Priority:  highest    |    Milestone:            
   Component:  Distro     |      Version:            
    Severity:  normal     |   Resolution:            
    Keywords:  HasPatch   |    Blockedby:            
Reproducible:             |     Blocking:            
--------------------------+-------------------------------------------------

Comment(by LeRoutier):

 My problem here is that when no DBUS connection could be done, it crashes
 because of a buffer overflow : the buffer that should contain the error
 message has a hardcoded 100 bytes length but in my case, the error message
 length is far longer.

 At least, "sprintf( buffer," should be replaced by snprintf or "g_snprintf
 ( buffer, LENGTH,"

 As we use glib functions, g_snprintf should be prefered.

-- 
Ticket URL: <https://docs.openmoko.org/trac/ticket/1834#comment:3>
docs.openmoko.org <http://docs.openmoko.org/trac/>
openmoko trac