r3670 - trunk/src/host/qemu-neo1973/hw

andrew at sita.openmoko.org andrew at sita.openmoko.org
Tue Dec 18 04:51:54 CET 2007


Author: andrew
Date: 2007-12-18 04:51:53 +0100 (Tue, 18 Dec 2007)
New Revision: 3670

Modified:
   trunk/src/host/qemu-neo1973/hw/s3c24xx_mmci.c
   trunk/src/host/qemu-neo1973/hw/sd.c
Log:
Fix signedness in s3c_mmci and remove bogus CRC bits in SD response type 2 generation.


Modified: trunk/src/host/qemu-neo1973/hw/s3c24xx_mmci.c
===================================================================
--- trunk/src/host/qemu-neo1973/hw/s3c24xx_mmci.c	2007-12-18 01:49:21 UTC (rev 3669)
+++ trunk/src/host/qemu-neo1973/hw/s3c24xx_mmci.c	2007-12-18 03:51:53 UTC (rev 3670)
@@ -130,7 +130,7 @@
 {
     int rsplen, i;
     struct sd_request_s request;
-    char response[16];
+    uint8_t response[16];
 
     request.cmd = s->ccontrol & 0x3f;
     request.arg = s->arg;

Modified: trunk/src/host/qemu-neo1973/hw/sd.c
===================================================================
--- trunk/src/host/qemu-neo1973/hw/sd.c	2007-12-18 01:49:21 UTC (rev 3669)
+++ trunk/src/host/qemu-neo1973/hw/sd.c	2007-12-18 03:51:53 UTC (rev 3670)
@@ -1216,13 +1216,11 @@
 
     case sd_r2_i:
         memcpy(response, sd->cid, sizeof(sd->cid));
-        response[7] |= 1;
         rsplen = 16;
         break;
 
     case sd_r2_s:
         memcpy(response, sd->csd, sizeof(sd->csd));
-        response[7] |= 1;
         rsplen = 16;
         break;
 





More information about the commitlog mailing list