r3378 - in trunk/src/target/OM-2007.2/libraries/libmokogsmd2: . libmokogsmd

[mickey at sita.openmoko.org]

Author: mickey
Date: 2007-11-08 16:11:26 +0100 (Thu, 08 Nov 2007)
New Revision: 3378

Modified:
   trunk/src/target/OM-2007.2/libraries/libmokogsmd2/ChangeLog
   trunk/src/target/OM-2007.2/libraries/libmokogsmd2/libmokogsmd/moko-gsmd-connection.c
Log:
libmokogsmd2: fix bogus error check in moko_gsmd_connection_set_antenna_power 


Modified: trunk/src/target/OM-2007.2/libraries/libmokogsmd2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/libraries/libmokogsmd2/ChangeLog	2007-11-08 14:36:34 UTC (rev 3377)
+++ trunk/src/target/OM-2007.2/libraries/libmokogsmd2/ChangeLog	2007-11-08 15:11:26 UTC (rev 3378)
@@ -1,5 +1,11 @@
 2007-11-08	Michael Lauer	<mickey at openmoko.org>
 
+	* libmokogsmd/moko-gsmd-connection.c: (moko_gsmd_connection_set_antenna_power):
+	Fix error check. The return code of lgsm_phone_power is the return code of
+	socket::send(), hence we better check for != -1.
+
+2007-11-08	Michael Lauer	<mickey at openmoko.org>
+
 	* libmokogsmd/moko-gsmd-connection.c: Add GSMD_EVT_IN_ERROR
 	* Add signal "cme-cms-error" and send it forth.
 

Modified: trunk/src/target/OM-2007.2/libraries/libmokogsmd2/libmokogsmd/moko-gsmd-connection.c
===================================================================
--- trunk/src/target/OM-2007.2/libraries/libmokogsmd2/libmokogsmd/moko-gsmd-connection.c	2007-11-08 14:36:34 UTC (rev 3377)
+++ trunk/src/target/OM-2007.2/libraries/libmokogsmd2/libmokogsmd/moko-gsmd-connection.c	2007-11-08 15:11:26 UTC (rev 3378)
@@ -472,15 +472,15 @@
 
     if (!priv->handle)
     {
-      g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_CONNECT, "Error connecting to gsmd");
-      return;
+        g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_CONNECT, "Error connecting to gsmd");
+        return;
     }
 
     result = lgsm_phone_power( priv->handle, on ? 1 : 0 );
 
-    if (result != 0)
+    if (result == -1)
     {
-      g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_POWER, "Error setting antenna power");
+         g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_POWER, "Error setting antenna power");
     }
 }