r3461 - in trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src/phone-kit

chris at sita.openmoko.org chris at sita.openmoko.org
Tue Nov 20 18:58:38 CET 2007


Author: chris
Date: 2007-11-20 18:58:35 +0100 (Tue, 20 Nov 2007)
New Revision: 3461

Modified:
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.c
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.h
Log:
        * src/phone-kit/moko-dialer-sms.c: (moko_dialer_sms_send):
        * src/phone-kit/moko-dialer-sms.h: 
        Return error message when trying to send an SMS after failing to
        connect to gsmd


Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog	2007-11-20 17:55:15 UTC (rev 3460)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog	2007-11-20 17:58:35 UTC (rev 3461)
@@ -1,3 +1,10 @@
+2007-11-20  Chris Lord  <chris at openedhand.com>
+
+	* src/phone-kit/moko-dialer-sms.c: (moko_dialer_sms_send):
+	* src/phone-kit/moko-dialer-sms.h:
+	Return error message when trying to send an SMS after failing to 
+	connect to gsmd
+
 2007-11-20  Thomas Wood  <thomas at openedhand.com>
 
 	* src/dialer/dialer-main.c: (dial_clicked_cb), (main): Use a message box

Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.c	2007-11-20 17:55:15 UTC (rev 3460)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.c	2007-11-20 17:58:35 UTC (rev 3461)
@@ -445,6 +445,13 @@
 
 	priv = SMS_PRIVATE (self);
 	
+	if (!priv->handle) {
+		/* Failed to connect to gsmd earlier */
+		*error = g_error_new (PHONE_KIT_SMS_ERROR,
+			PK_SMS_ERROR_GSMD, "Failed to connect to gsmd");
+		return FALSE;
+	}
+	
 	/* Ask for delivery report */
 	sms.ask_ds = 1;
 	

Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.h
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.h	2007-11-20 17:55:15 UTC (rev 3460)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-dialer-sms.h	2007-11-20 17:58:35 UTC (rev 3461)
@@ -31,7 +31,8 @@
 
 typedef enum {
 	PK_SMS_ERROR_NO_TOOLONG,
-	PK_SMS_ERROR_MSG_TOOLONG
+	PK_SMS_ERROR_MSG_TOOLONG,
+	PK_SMS_ERROR_GSMD,
 } PhoneKitSMSError;
 
 typedef struct {





More information about the commitlog mailing list