r3002 - in trunk/src/target/OM-2007.2/applications/openmoko-browser2: . src

zecke at sita.openmoko.org zecke at sita.openmoko.org
Tue Sep 18 03:40:59 CEST 2007


Author: zecke
Date: 2007-09-18 03:40:58 +0200 (Tue, 18 Sep 2007)
New Revision: 3002

Modified:
   trunk/src/target/OM-2007.2/applications/openmoko-browser2/ChangeLog
   trunk/src/target/OM-2007.2/applications/openmoko-browser2/src/current-page.c
Log:
2007-09-17 Holger Hans Peter Freyther <zecke at selfish.org>

        Work around another Gtk+ crash. If we remove a WebKitGtkPage
        and add another one (gtk_container_{add,remove}) without accesing
        the event loop we will get a crash.
        The work around is to switch to the selection page to select a webpage

        * src/current-page.c:
        (current_close_page):


Modified: trunk/src/target/OM-2007.2/applications/openmoko-browser2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-browser2/ChangeLog	2007-09-18 01:40:57 UTC (rev 3001)
+++ trunk/src/target/OM-2007.2/applications/openmoko-browser2/ChangeLog	2007-09-18 01:40:58 UTC (rev 3002)
@@ -1,5 +1,15 @@
 2007-09-17  Holger Hans Peter Freyther  <zecke at selfish.org>
 
+        Work around another Gtk+ crash. If we remove a WebKitGtkPage
+        and add another one (gtk_container_{add,remove}) without accesing
+        the event loop we will get a crash.
+        The work around is to switch to the selection page to select a webpage
+
+        * src/current-page.c:
+        (current_close_page):
+
+2007-09-17  Holger Hans Peter Freyther  <zecke at selfish.org>
+
         Change the button label depending on if we are going
         to search or to navigate to a url directly.
 

Modified: trunk/src/target/OM-2007.2/applications/openmoko-browser2/src/current-page.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-browser2/src/current-page.c	2007-09-18 01:40:57 UTC (rev 3001)
+++ trunk/src/target/OM-2007.2/applications/openmoko-browser2/src/current-page.c	2007-09-18 01:40:58 UTC (rev 3002)
@@ -73,8 +73,8 @@
     /* To destroy the WebKitGtkPage we will g_object_unref it */
     struct BrowserPage* oldCurrent = data->currentPage;
     data->browserPages = g_list_remove (data->browserPages, oldCurrent);
-    struct BrowserPage* newPage = g_list_first(data->browserPages) ? g_list_first(data->browserPages)->data : NULL;
-    set_current_page (newPage, data);
+    set_current_page (NULL, data);
+    gtk_notebook_set_current_page (GTK_NOTEBOOK (data->mainNotebook), 2);
 
 
     g_object_unref (oldCurrent->webKitPage);





More information about the commitlog mailing list