development tree for U-Boot: Changes to 'andy'

git at git at
Wed Aug 6 15:38:06 CEST 2008

Rebased ref, commits from common ancestor:
commit 676aebf919b8e80152eea50a69b9f39cb2cb35ba
Author: Andy Green <andy at>
Date:   Wed Aug 6 14:37:10 2008 +0100

    Signed-off-by: Andy Green <andy at>

commit 64eb10cab8055084ae25ea4e73b66dd03cc1a0cb
Author: Simon Kagstrom <simon.kagstrom at>
Date:   Sun Aug 3 23:39:08 2008 +0100

    Add a U-boot environment option ("stop_in_menu") which, if set to 'yes', will
    always stop the board in the U-boot menu. Reduces the wear on the AUX
    button for me at least :-)
    Signed-off-by: Simon Kagstrom <simon.kagstrom at>

commit aa9b0ea7a1c9277fe0e9bfbda5070a9c9d61eaff
Author: Andy Green <andy at>
Date:   Sun Aug 3 19:34:57 2008 +0100

    We can't afford turning off interrupts for long periods in
    U-Boot as the USB stack fails and leaves the USB device in
    Insane Spam Mode.
    This patch allowed 50 resets in a row giving normal USB
    behaviour with no sign of the issue any more.
    Signed-off-by: Andy Green <andy at>

commit e8be8149e66a84c9576aea01b38c4c8fdb6677a6
Author: Andy Green <andy at>
Date:   Sun Aug 3 19:34:48 2008 +0100

    Someone left us a big fat warning in USB device code
    	/* Don't ever put [serial] debugging in non-error codepaths here, it
    	 * will violate the tight timing constraints of this USB Device
    	 * controller (and lead to bus enumeration failures) */
    these "non-error codepaths" go all over the shop, this patch nukes some
    serial printf()s that can do what we must never do.
    Signed-off-by: Andy Green <andy at>

commit 8e307f5847af04c975922ba1eb5d97e8dbfb600c
Author: Andy Green <andy at>
Date:   Sun Aug 3 19:34:38 2008 +0100

    This patch ties up udc closedown before starting Linux, and
    makes sure the endpoints are off in the hardware.
    Signed-off-by: Andy Green <andy at>

commit c7994820c491ad1cdff28d5ff9b062d2c79d5f2c
Author: Andy Green <andy at>
Date:   Fri Aug 1 07:47:06 2008 +0100

    The USB callback for udc / enumeration notification is very time
    critical.  Recently, we started using this for PMU actions, which
    occur on the ridiculously slow I2C bus and block the USB stack for
    the duration.
    This caused a very bad behaviour in the USB Device hardware of
    spamming the USB bus at 6MHz for the entire session, even after
    Linux had booted, rendering the USB interface not operational.
    The chances were about 50:50 per boot you would have broken USB.
    This patch removes the I2C action from the time critical path
    and instead takes care to track it only if we are spinning
    waiting for enumeration because we have a bad battery level.
    The I2C transaction then takes place out of any time critical
    Enumeration is lost anyway as soon as we enter Linux where the
    device is enumerated fresh and the Linux pcf50633 driver will
    handle it.
    One of the results of Insane Spam Mode on USB is not being able
    to enumerate properly with host PC over USB.  And that leads
    directly to not being able to charge the device for the whole
    Signed-off-by: Andy Green <andy at>

More information about the commitlog mailing list