r3779 - in trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src/phone-kit

chris at sita.openmoko.org chris at sita.openmoko.org
Mon Jan 7 11:45:29 CET 2008


Author: chris
Date: 2008-01-07 11:45:28 +0100 (Mon, 07 Jan 2008)
New Revision: 3779

Modified:
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c
Log:
        * src/phone-kit/moko-sms.c: (on_incoming_ds):
        Correct a misinterpretation of how delivery status reports are stored


Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog	2008-01-07 07:17:44 UTC (rev 3778)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog	2008-01-07 10:45:28 UTC (rev 3779)
@@ -1,3 +1,8 @@
+2008-01-07  Chris Lord  <chris at openedhand.com>
+
+	* src/phone-kit/moko-sms.c: (on_incoming_ds):
+	Correct a misinterpretation of how delivery status reports are stored
+
 2007-12-21  Chris Lord  <chris at openedhand.com>
 
 	* src/phone-kit/moko-sms.c: (on_incoming_ds):

Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c	2008-01-07 07:17:44 UTC (rev 3778)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c	2008-01-07 10:45:28 UTC (rev 3779)
@@ -349,10 +349,8 @@
   MokoSms *moko_sms = MOKO_SMS (listener);
   MokoSmsPrivate *priv = moko_sms->priv;
 
-  /* TODO: I'm not entirely sure of the spec when if 
-   *       storing an unsent message means it failed?
-   */
-  if (sms->payload.coding_scheme == LGSM_SMS_STO_SENT) {
+  if ((sms->payload.coding_scheme == TP_STATUS_RECEIVED_OK) &&
+      (sms->stat == LGSM_SMS_STO_SENT)) {
     gchar *ref = g_strdup_printf ("%d", sms->index);
     JanaStoreView *view = jana_store_get_view (priv->sms_store);
     MokoSmsStatusReport *sr = g_slice_new (MokoSmsStatusReport);





More information about the commitlog mailing list