r3782 - in trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src/phone-kit

chris at sita.openmoko.org chris at sita.openmoko.org
Mon Jan 7 16:48:28 CET 2008


Author: chris
Date: 2008-01-07 16:48:27 +0100 (Mon, 07 Jan 2008)
New Revision: 3782

Modified:
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
   trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c
Log:
        * src/phone-kit/moko-sms.c: (on_incoming_ds):
        Don't check the stat of the delivery report, no need as we have the ref
        anyway and I must be misinterpreting its meaning. Also switch around a
        debug comment to make it more clear.


Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog	2008-01-07 15:15:22 UTC (rev 3781)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog	2008-01-07 15:48:27 UTC (rev 3782)
@@ -1,5 +1,12 @@
 2008-01-07  Chris Lord  <chris at openedhand.com>
 
+	* src/phone-kit/moko-sms.c: (on_incoming_ds):
+	Don't check the stat of the delivery report, no need as we have the ref
+	anyway and I must be misinterpreting its meaning. Also switch around a
+	debug comment to make it more clear.
+
+2008-01-07  Chris Lord  <chris at openedhand.com>
+
 	* src/phone-kit/moko-network.c: (retry_oper_get),
 	(retry_opers_get), (retry_get_imsi), (on_network_registered),
 	(moko_network_dispose), (net_msghandler), (phone_msghandler):

Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c	2008-01-07 15:15:22 UTC (rev 3781)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/phone-kit/moko-sms.c	2008-01-07 15:48:27 UTC (rev 3782)
@@ -349,8 +349,9 @@
   MokoSms *moko_sms = MOKO_SMS (listener);
   MokoSmsPrivate *priv = moko_sms->priv;
 
-  if ((sms->payload.coding_scheme == TP_STATUS_RECEIVED_OK) &&
-      (sms->stat == LGSM_SMS_STO_SENT)) {
+  g_debug ("Received sent SMS status report");
+  if ((sms->payload.coding_scheme == TP_STATUS_RECEIVED_OK)/* &&
+      (sms->stat == LGSM_SMS_STO_SENT)*/) {
     gchar *ref = g_strdup_printf ("%d", sms->index);
     JanaStoreView *view = jana_store_get_view (priv->sms_store);
     MokoSmsStatusReport *sr = g_slice_new (MokoSmsStatusReport);
@@ -358,7 +359,7 @@
     sr->moko_sms = g_object_ref (moko_sms);
     sr->ref = ref;
     
-    g_debug ("Received sent SMS status report");
+    g_debug ("Report signals success");
     jana_store_view_add_match (view, JANA_STORE_VIEW_CATEGORY, "Sending");
     g_signal_connect (view, "added",
                       G_CALLBACK (status_report_added_cb), sr);





More information about the commitlog mailing list