Reason for GPS problems found! / more patches

Andy Green andy at openmoko.com
Tue Jul 22 17:34:58 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| On Tue, 22 Jul 2008 16:25:45 +0200, Andy Green <andy at openmoko.com> wrote:
|
|>
http://git.openmoko.org/?p=kernel.git;a=commitdiff;h=66a83c97c4545ce4f07e0d90998f906fae49caf2
|
|> static int sd_drive;
|
| This doesn't seem like zero initialization to me.

I guess you're not a kernel coder... not only is the segment for these
definitively zero at start of kernel, but it is an offence against
./scripts/checkpatch.pl to explicitly zero these things.

I often forget that and zero them anyway because I like to see it, but
most times I remember to run checkpatch and have to go back and "fix"
myself...

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkiF/iIACgkQOjLpvpq7dMq6ZACgjRipRwzoKXDeLsP1mrBYQP1F
sOsAn2dTjbwPDVwcx5LopCGwHp4oRVT0
=WiHe
-----END PGP SIGNATURE-----




More information about the community mailing list