[PATCH 1/2] Avoid "QString::arg: Argument missing" logs

Neil Jerram neil at ossau.homelinux.net
Tue Nov 20 23:53:00 CET 2012


Specifically these:
Nov 20 22:09:04 neo Qtopia: QString::arg: Argument missing: "1 missed", @/Communications/Calls/MissedCalls
Nov 20 22:09:04 neo Qtopia: QString::arg: Argument missing: "1 new", @/Communications/Messages/NewMessages

These arise because the "faen"-derived themes have special cases for 1
missed call and 1 new message - presumably for translation into
languages where the 1 case is different from N != 1.  All those places
have an unnecessary <trarg>, which causes the logs, and which this
commit removes.
---
 etc/themes/faenqo/home.xml           |    2 +-
 etc/themes/faenqomod/home.xml        |    2 +-
 etc/themes/mokofaen/home.xml         |    2 +-
 etc/themes/mokofaen/home_classic.xml |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/etc/themes/faenqo/home.xml b/etc/themes/faenqo/home.xml
index 1be7db7..a511d48 100644
--- a/etc/themes/faenqo/home.xml
+++ b/etc/themes/faenqo/home.xml
@@ -60,7 +60,7 @@
 		</layout>
 		<rect rect="0,25pt,0x18pt">
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages == 1">
-				<tr><trtext>1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
+				<tr><trtext>1 new</trtext></tr>
 			</text>
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages > 1">
 				<tr><trtext>%1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
diff --git a/etc/themes/faenqomod/home.xml b/etc/themes/faenqomod/home.xml
index 68d4dab..8590b3b 100644
--- a/etc/themes/faenqomod/home.xml
+++ b/etc/themes/faenqomod/home.xml
@@ -95,7 +95,7 @@
 		</layout>
 		<rect rect="0,25pt,0x18pt">
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages == 1">
-				<tr><trtext>1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
+				<tr><trtext>1 new</trtext></tr>
 			</text>
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages > 1">
 				<tr><trtext>%1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
diff --git a/etc/themes/mokofaen/home.xml b/etc/themes/mokofaen/home.xml
index 1380bc2..6fd654f 100755
--- a/etc/themes/mokofaen/home.xml
+++ b/etc/themes/mokofaen/home.xml
@@ -85,7 +85,7 @@
 		</layout>
 		<rect rect="0,25pt,0x18pt">
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages == 1">
-				<tr><trtext>1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
+				<tr><trtext>1 new</trtext></tr>
 			</text>
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages > 1">
 				<tr><trtext>%1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
diff --git a/etc/themes/mokofaen/home_classic.xml b/etc/themes/mokofaen/home_classic.xml
index 5f4eaaf..439771a 100755
--- a/etc/themes/mokofaen/home_classic.xml
+++ b/etc/themes/mokofaen/home_classic.xml
@@ -98,7 +98,7 @@
 		</layout>
 		<rect rect="0,25pt,0x18pt">
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages == 1">
-				<tr><trtext>1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
+				<tr><trtext>1 new</trtext></tr>
 			</text>
 			<text rect="0,0,0x9pt" align="hcenter" bold="yes" color="#ffffff" outline="#000000" transient="yes" active="expr:@/Communications/Messages/NewMessages > 1">
 				<tr><trtext>%1 new</trtext><trarg>@/Communications/Messages/NewMessages</trarg></tr>
-- 
1.7.10.4


--=-=-=


This is a simple bug fix and, I believe, uncontroversial.

Sorry for making your release work a bit bigger.  Mokofaen for me is
part of the everyday happiness of using a free phone.

Regards,
        Neil

--=-=-=--



More information about the community mailing list