OK. I have committed your patch to my main repository. Now building binaries.<br><br><div class="gmail_quote">On Mon, Mar 9, 2009 at 8:21 PM, Chris Samuel <span dir="ltr"><<a href="mailto:chris@csamuel.org">chris@csamuel.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">The original Qt Extended 4.4.3 initially set both echo<br>
suppression and noise reduction in separate AT commands<br>
which might result in the second command negating the<br>
first one. It also only set them for outgoing calls.<br>
<br>
This new version uses the AT command to set both<br>
echo suppression and noise reduction at the same<br>
time as well as setting them on initialisation and<br>
after a wake up.<br>
<br>
This is identical to the patch against QtE 4.4.2 and<br>
applied cleanly with no fuzz with QtE 4.4.3.<br>
<br>
Signed-off-by: Chris Samuel <<a href="mailto:chris@csamuel.org">chris@csamuel.org</a>><br>
---<br>
.../src/plugins/phonevendors/neo/vendor_neo.cpp | 17 ++++++++++++++---<br>
1 files changed, 14 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp<br>
index d27b4eb..35f7a0b 100644<br>
--- a/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp<br>
+++ b/devices/neo/src/plugins/phonevendors/neo/vendor_neo.cpp<br>
@@ -153,8 +153,7 @@ QString NeoCallProvider::dialVoiceCommand(const QDialOptions& options) const<br>
// do undocumented echo cancellation and noise reduction<br>
<br>
modemService->primaryAtChat()->chat( "AT@ST=\"-26\"" );<br>
- modemService->primaryAtChat()->chat( "AT%N028B" );<br>
- modemService->primaryAtChat()->chat( "AT%N0125" );<br>
+ modemService->primaryAtChat()->chat( "AT%N0187" );<br>
return QModemCallProvider::dialVoiceCommand(options);<br>
}<br>
<br>
@@ -551,11 +550,14 @@ NeoModemService::NeoModemService<br>
<br>
// chat("AT%CMGRS=1"); //message transmission to get any failed sms during suspend<br>
<br>
- chat("AT%SLEEP=2"); //makes my Moko8 not respond to calls during sosuend<br>
+ chat("AT%SLEEP=2"); //makes my Moko8 not respond to calls during suspend<br>
// Turn cell id information back on.<br>
chat( "AT+CREG=2" );<br>
chat( "AT+CGREG=2" );<br>
<br>
+ // Turn on echo suppression and noise reduction.<br>
+ chat( "AT%N0187" );<br>
+<br>
QTimer::singleShot(200, this, SLOT(sendRego()));<br>
}<br>
<br>
@@ -572,6 +574,9 @@ void NeoModemService::sendRego()<br>
if( !cfg.value("PlaneMode",false).toBool()) {<br>
// chat("AT%NRG=0,0"); //force auto operations<br>
chat("AT+COPS=0"); //force auto operations<br>
+<br>
+ // Turn on echo suppression and noise reduction.<br>
+ chat( "AT%N0187" );<br>
}<br>
}<br>
<br>
@@ -679,6 +684,9 @@ void NeoModemService::reset()<br>
chat("AT%CWUP=1");<br>
chat("ATE0");<br>
<br>
+ // Turn on echo suppression and noise reduction.<br>
+ chat( "AT%N0187" );<br>
+<br>
// Turn on "%CNAP" notifications, which supply the caller's<br>
// name on an call. Only supported on some networks.<br>
chat( "AT%CNAP=1" );<br>
@@ -738,6 +746,9 @@ void NeoModemService::wake()<br>
<br>
// Re-enable signal quality notifications when the system wakes up again.<br>
chat( "AT%CSQ=1", this, SLOT(mcsqOn()) );<br>
+<br>
+ // Turn on echo suppression and noise reduction.<br>
+ chat( "AT%N0187" );<br>
}<br>
<br>
void NeoModemService::mcsqOff()<br>
<font color="#888888">--<br>
1.5.6.3<br>
<br>
<br>
_______________________________________________<br>
Openmoko community mailing list<br>
<a href="mailto:community@lists.openmoko.org">community@lists.openmoko.org</a><br>
<a href="http://lists.openmoko.org/mailman/listinfo/community" target="_blank">http://lists.openmoko.org/mailman/listinfo/community</a><br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Best Regards<br><br>HouYu Li, Karajan<br><br>karajan_ii (at) <a href="http://hotmail.com">hotmail.com</a><br>karadog (at) <a href="http://gmail.com">gmail.com</a><br>
lihouyu (at) <a href="http://phpex.net">phpex.net</a><br><br>PHP Developer<br>Red Hat Certified Engineer<br><br>Shanghai, China<br>