<div dir="ltr"><br><br><div class="gmail_quote">On Tue, Apr 7, 2009 at 1:37 PM, Timo Juhani Lindfors <span dir="ltr"><<a href="mailto:timo.lindfors@iki.fi">timo.lindfors@iki.fi</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
Tom <<a href="mailto:tom@stosb.com">tom@stosb.com</a>> writes:<br>
> please make sure to send me bug reports/ideas/patches.<br>
<br>
I did not test this yet but here are my comments based on reading the<br>
source tarball:<br>
<br>
* Thanks for using autotools. It helps a lot that simple autoreconf -i<br>
&& ./configure && make && make install works and DESTDIR and<br>
--prefix are respected.<br>
<br>
* Code has comments, way to go! :-)<br>
<br>
* #define GLADE_FILE "/usr/share/callrec/callrec.glade" is hardcoded<br>
to source code and does not respect --prefix. This means I can not<br>
install callrec as normal user to my home directory.</blockquote><div>I know, should be fixed, thanks for reminding me. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
* There's a stray \r in the end of callrec.c</blockquote><div>Thanks. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
* Please consider making the state.patch with "diff -u" so that it has<br>
context.<br>
<br>
19,20c19,20<br>
< value.0 0<br>
< value.1 0<br>
---<br>
> value.0 195<br>
> value.1 195<br>
<br>
is not very readable since you don't know what control it is<br>
changing.</blockquote><div>I know, i already changed this locally, forgot to up it to public svn. doing it now.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
* There are three state files but only one patch. Which statefile is<br>
the patch for? If you have time it would be nice to have some<br>
discussion on what each control does. Does this program record both<br>
parties of the conversation in the same channel or are they recorded<br>
as different channels?</blockquote><div>it is stated in the wiki, each side gets a channel. furthermore, them same as for the patch type, <br>I already changed that.<br>state.patch was used (without context) because I wanted to try and make "a global patch", though this<br>
didn't go as well as I expected, so I changed it.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
* The only license to distribute gartoon redux icon theme 1.7 is GPL<br>
version 2:<br>
<br>
"This package is free software; you can redistribute it and/or modify<br>
it under the terms of the GNU General Public License as published by<br>
the Free Software Foundation; version 2 dated June, 1991."<br>
<br>
This might be a problem for your GPLv3 or later application. However,<br>
note that version 1.8 gives you a license to distribute it under later<br>
versions too:<br>
<br>
"* Change license to GPL v2 or later." </blockquote><div>Thanks, I didn't notice that, I just had it lying around so I used it . ;] <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
<br>
<br>
best regards,<br>
<font color="#888888">Timo Lindfors<br>
</font></blockquote></div><br></div>