[PATCH] Wait until device is ready after status request

Tormod Volden lists.tormod at gmail.com
Mon Nov 8 23:04:38 CET 2010


On Mon, Nov 8, 2010 at 12:21 PM, Stefan Schmidt wrote:
>> In one case below it replaces a hardcoded 5 ms wait. If a device
>> is broken and needs more time than it says, we should add quirks
>> for the specific device.
>
> I agree with the concept, but we would need such a quirk system in place before
> we change the default. The main problem is here that our main target the
> Openmoko devices are broken in this regard. It does not report the time in
> bwPollTimeout correctly.
>
> So I'm not going to apply this patch until such a quirk system exists.

I was browsing through the archive now and I see that this has been
brought up before. Do your OpenMokos return 0, or some insane value?
The DFU standard generously allows up to 4.7 hours :)

I would like to make something a bit more nicer than a uncommented,
magic 5000, also before we have a full quirk system in place.

BTW, thanks for testing it on an OpenMoko, which I can not do. I
understand dfu-util was originally made for it, so I respect that we
do not want to break it.

Tormod



More information about the devel mailing list