[PATCH] dfu-util: Don't sleep unnecessarily
stefan at datenfreihafen.org
Wed Mar 9 17:27:20 CET 2011
On Wed, 2011-03-09 at 20:14, Bernard Blackham wrote:
> > On Wed, 2011-03-09 at 16:49, Bernard Blackham wrote:
> > > The DFU spec says that bwPollTimeout is the amount of time that
> > > should pass between DFU_GETSTATUS requests. If the status is
> > > already good, we do not need to sleep as we will not poll again.
> > >
> > > This speeds up DFU downloads directly into memory.
> > Interesting point. What target you are testing this against?
> This is on a Beagleboard-xM, with a custom patch to u-boot for DFU
Great. Are you going to work on getting this into upstream u-boot?
> One point to note - like the OpenMoko version (which it was based
> upon), the current u-boot patch does not populate bwPollTimeout
> correctly. I will be posting a fixed patch shortly, so it will not
> need a quirk. If people ask, please direct them to fix their u-boot
> instead :)
Getting the correct timeout from u-boot would indeed be great. :)
We still will need quirks for released products where people are not going to
change the bootloader but going forward it would be nice to no longer have need
for this quirk.
If you are loking for more bugs there is also a problem with DFU upload in the
u-boot patches. :)
More information about the devel