[PATCH] dfu-util: Don't sleep unnecessarily

Bernard Blackham b-openmoko at largestprime.net
Thu Mar 10 23:37:53 CET 2011

On Wed, Mar 09, 2011 at 05:27:20PM +0100, Stefan Schmidt wrote:
> > This is on a Beagleboard-xM, with a custom patch to u-boot for DFU
> > support:
> > 
> > http://groups.google.com/group/beagleboard/browse_thread/thread/d837e52e29a583d4/
> Great. Are you going to work on getting this into upstream u-boot?

I would love to, but don't have the time at the moment to clean up
the patch.  It's very hacky in places, and I can see why it's not
upstream already! I'll probably consider it though next time I have
to merge the patch into future u-boots!

> Getting the correct timeout from u-boot would indeed be great. :)

For the archives, the current latest version that fixes this is
(google's search functionality doesn't make it easy to find!)

> If you are loking for more bugs there is also a problem with DFU
> upload in the u-boot patches. :)

So that latest patch above also fixed uploads for me (at least into
RAM - haven't tested flash).  The problem that I had was that the
pointer to read from (ds->ptr) for uploads was never initialised.

Were there any other bugs with upload?

There's also modifications in my beagle u-boot patch that makes
DFU's RAM partition obey ${loadaddr} for download/upload, and
${filesize} for upload (no more hard-coded 0x200000).  I'll try to
get some time to push those patches into the openmoko tree (though I
don't have any devices to test on, so I may call for a patch test
monkey :)


More information about the devel mailing list