[PATCH 4/4] dfu_load: Move file opening/closing into main.c

Stefan Schmidt stefan at datenfreihafen.org
Fri May 20 16:46:43 CEST 2011


On Fri, 2011-05-20 at 00:03, Tormod Volden wrote:
> From: Tormod Volden <debian.tormod at gmail.com>
> Prepares for some future enhancements like file suffix parsing,
> so we can avoid opening the same file several times.
> Also pass dif structure instead of separate usb handle and interface
> when we call upload and download functions. At this point we are only
> dealing with one interface anyway, so we can abstract it in a dif
> structure. This will also allow the functions to access other dif
> members without using loads of function call parameters.

Looks good. It does apply as well but seem to need to the other two
patches to compile. Will go in when the others are ready.

If it makes your life easier I could also merge from your git tree
after review.

Stefan Schmidt

More information about the devel mailing list