[PATCH 1/2] dfu_file.c: Add parsing of DFU file suffix

Stefan Schmidt stefan at datenfreihafen.org
Mon May 23 19:39:53 CEST 2011


Great to see that dfu-util finally gets suffix support. :)

On Sat, 2011-05-21 at 01:49, Tormod Volden wrote:
> From: Tormod Volden <debian.tormod at gmail.com>
> The new dfu_file structure is used to keep track of the download (or
> upload) file. parse_dfu_suffix() will parse an (already opened) file and
> populate the struct members corresponding to the DFU suffix fields.
> The commit also includes some verification of the suffix fields,
> but at this point only warns about mismatches, with one exception:
> If there is a valid DFU suffix, it must have DFU revision 1.0,
> otherwise we abort the download.

Thats because we are only supporting version 1.0 of the spec right
now? If yes, thats fair enough and we can adjust it once 1.1 support
has landed.

> This patch is for the libusb-1.0 branch. I have done some testing, but
> since I don't have any really DFU compliant device, more testing is
> welcome. Currently the print_dfu_if fix from master must be merged
> or cherry-picked as well.

I cherry-picked the commit into libusb-1.0 now.

More information about the devel mailing list