dfu_util: bugfix for crash
Stefan Schmidt
stefan at datenfreihafen.org
Thu Nov 17 19:41:36 CET 2011
Hello.
On Wed, 2011-11-16 at 18:45, Satz Klauer wrote:
>
> I found a small bug in dfu_util, file main.c function find_dfu_if() line 86:
Did you hit this problem somewhere?
> There a function libusb_get_config_descriptor(dev, cfg_idx, &cfg); is
> called without checking the return code. In case it fails cfg is
> invalid and will lead to an crash some lines later.
>
> Something like
>
> rc=libusb_get_config_descriptor(dev, cfg_idx, &cfg);
> if (rc<0) return rc;
> /* in some cases, noticably FreeBSD if uid != 0,
> * the configuration descriptors are empty */
>
> would fix that problem.
Thanks for bringing this to our attention. Tormod prepared a patch for
it and I applied it. Does this covers your concers?
http://cgit.openezx.org/dfu-util/commit/?id=60bb907b9b30f74bbd9ddafbba6064e1fbbd52ad
New and shiny jenkins autobuild results can now be foundhere btw:
http://jenkins.osmocom.org/jenkins/job/dfu-util/
regards
Stefan Schmidt
More information about the devel
mailing list