gta01 vibrator cleanups
Pavel Machek
pavel at ucw.cz
Wed Apr 4 11:50:36 CEST 2007
Hi!
I guess the code should not call itself led when it is a vibrator, and
it definitely should not call itself spitzled.
Signed-off-by: Pavel Machek <pavel at suse.cz>
diff --git a/drivers/leds/leds-gta01.c b/drivers/leds/leds-gta01.c
index d78e4e2..ebb05bf 100644
--- a/drivers/leds/leds-gta01.c
+++ b/drivers/leds/leds-gta01.c
@@ -21,7 +21,7 @@ #include <asm/mach-types.h>
#include <asm/arch/hardware.h>
#include <asm/arch/gta01.h>
-static void gta01led_vib_set(struct led_classdev *led_cdev, enum led_brightness value)
+static void gta01vib_vib_set(struct led_classdev *led_cdev, enum led_brightness value)
{
if (value)
s3c2410_gpio_setpin(GTA01_GPIO_VIBRATOR_ON, 1);
@@ -31,24 +31,24 @@ static void gta01led_vib_set(struct led_
static struct led_classdev gta01_vib_led = {
.name = "gta01:vibrator",
- .brightness_set = gta01led_vib_set,
+ .brightness_set = gta01vib_vib_set,
};
#ifdef CONFIG_PM
-static int gta01led_suspend(struct platform_device *dev, pm_message_t state)
+static int gta01vib_suspend(struct platform_device *dev, pm_message_t state)
{
led_classdev_suspend(>a01_vib_led);
return 0;
}
-static int gta01led_resume(struct platform_device *dev)
+static int gta01vib_resume(struct platform_device *dev)
{
led_classdev_resume(>a01_vib_led);
return 0;
}
#endif
-static int gta01led_probe(struct platform_device *pdev)
+static int gta01vib_probe(struct platform_device *pdev)
{
int ret;
@@ -58,38 +58,38 @@ static int gta01led_probe(struct platfor
return led_classdev_register(&pdev->dev, >a01_vib_led);
}
-static int gta01led_remove(struct platform_device *pdev)
+static int gta01vib_remove(struct platform_device *pdev)
{
led_classdev_unregister(>a01_vib_led);
return 0;
}
-static struct platform_driver gta01led_driver = {
- .probe = gta01led_probe,
- .remove = gta01led_remove,
+static struct platform_driver gta01vib_driver = {
+ .probe = gta01vib_probe,
+ .remove = gta01vib_remove,
#ifdef CONFIG_PM
- .suspend = gta01led_suspend,
- .resume = gta01led_resume,
+ .suspend = gta01vib_suspend,
+ .resume = gta01vib_resume,
#endif
.driver = {
.name = "gta01-led",
},
};
-static int __init spitzled_init(void)
+static int __init gta01vib_init(void)
{
- return platform_driver_register(>a01led_driver);
+ return platform_driver_register(>a01vib_driver);
}
-static void __exit spitzled_exit(void)
+static void __exit gta01vib_exit(void)
{
- platform_driver_unregister(>a01led_driver);
+ platform_driver_unregister(>a01vib_driver);
}
-module_init(spitzled_init);
-module_exit(spitzled_exit);
+module_init(gta01vib_init);
+module_exit(gta01vib_exit);
MODULE_AUTHOR("Harald Welte <laforge at openmoko.org>");
-MODULE_DESCRIPTION("FIC GTA01 LED driver");
+MODULE_DESCRIPTION("FIC GTA01 vibrator driver");
MODULE_LICENSE("GPL");
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
More information about the openmoko-kernel
mailing list