[PATCH] jbt6k74: error checking and possible cleanup.

Arnaud Patard (Rtp) arnaud.patard at rtp-net.org
Tue Mar 27 14:07:53 CEST 2007

Stefan Schmidt <stefan at datenfreihafen.org> writes:

> Hello.
> On Sat, 2007-03-24 at 16:14, Stefan Schmidt wrote:
>> On Sat, 2007-03-24 at 13:36, Arnaud Patard wrote:
>> > 
>> > doh... 5 calls to device_create_file() ... now, with the checks, that
>> > begins to be ugly. Please consider the use of sysfs_create_group()
>> > instead.
>> Goof point. I was not aware of sysfs_create_group(). I'll look into
>> it.
> New version with sysfs_{create, remove}_group attched.

much better :)

While building a custom kernel for the neo yesterday, I've seen that
other moko patches needs similar treatment :(
Now that I have a build environment working for the neo, _if_ I have
enough time, I'll look at fixing this and maybe remove most of the build


More information about the openmoko-kernel mailing list