[PATCH] hxd8-audio.patch

Harald Welte laforge at openmoko.org
Wed May 16 06:19:59 CEST 2007

On Tue, May 15, 2007 at 06:57:59PM +0800, Alec_Tsai wrote:

> -static const snd_kcontrol_new_t wm8976_left_mixer_controls[] = {
> +static const struct snd_kcontrol_new wm8976_left_mixer_controls[] = {

I guess those kind of changes are neccessarry because our ASoC version
is too old?  Can anyone please advise me what those changes are and why
they were made?  Also, do those wm8976 codec driver changes originate at
wolfson, or were they made by fiwin?

Maybe we should update our ASoC patch in svn? 

> +    /* set MCLK division for sample rate */
> +    ret = cpu_dai->dai_ops.set_clkdiv(cpu_dai, S3C24XX_DIV_MCLK,
> +        S3C2410_IISMOD_32FS );
> +    if (ret < 0)
> +        return ret;

this is not tab-indented, please fix the coding style to match the rest
of the code

> +	int reg=kcontrol->private_value & 0xFF;

please use space between and after '='

Please re-submit after incorporating my change requests and responding
to my questions above.  Thanks!

- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
Software for the world's first truly open Free Software mobile phone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hxd8-audio.patch
Type: application/octet-stream
Size: 21683 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20070516/5445bb81/attachment.obj 

More information about the openmoko-kernel mailing list