[PATCH] hxd8-resume.patch

Harald Welte laforge at openmoko.org
Tue May 22 13:50:36 CEST 2007

Hi Matt!

The patch seems fine to me (style-wise), however:

On Sun, May 20, 2007 at 04:13:20PM +0800, matt_hsu wrote:
> Log:
> 	HXD8: GPG[15:13] must be selected as input for resuming from u-boot.

the most important bit is missing: WHY?

This information should be present in both the Log, as well as a comment
in the actual source code.  Remember, lots of people will only have
access to the source code, and not the schematics.  Still, they want to
understand what is actually going on.

Please resubmit.  Thanks!
- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
Software for the world's first truly open Free Software mobile phone

More information about the openmoko-kernel mailing list