Arnaud Patard (Rtp)
arnaud.patard at rtp-net.org
Tue May 22 18:20:49 CEST 2007
matt_hsu <matt_hsu at openmoko.org> writes:
> Â ºï¼2007-05-22 Â 13:50 +0200ï¼Harald Welte ÂåÂ°ï¼
>> Hi Matt!
>> The patch seems fine to me (style-wise), however:
>> On Sun, May 20, 2007 at 04:13:20PM +0800, matt_hsu wrote:
>> > Log:
>> > HXD8: GPG[15:13] must be selected as input for resuming from u-boot.
>> the most important bit is missing: WHY?
> I checked the source, it's result from s3c2410_ts_connect() in
> s3c2410_ts.c. Even the GPIO configuration (GPGCON) is correct in uboot.
> TS module would modify these important bits.
> But doesn't these bits affect resume logic for GTA01?
> This caution is not mentioned in S3C2410 datasheet.
> That is, GPG[13:15] are not functional pins in NAND boot mode in 2410.
> So I think this patch should be applied on GTA02 if TS module is
hmmm... Sorry, but I don't understand. When loaded, the ts driver configures
the gpio to "ts mode" and doesn't play anymore with them. Nothing to do
And if you fear about loosing the gpio registers acrosss suspend/resume,
there's no problem too iirc. Look at pm stuff (in plat-s3c24xx), you
should find a function saving/restoring the correct values on suspend/resume.
>> This information should be present in both the Log, as well as a comment
>> in the actual source code. Remember, lots of people will only have
>> access to the source code, and not the schematics. Still, they want to
>> understand what is actually going on.
>> Please resubmit. Thanks!
More information about the openmoko-kernel