[PATCH] hxd8-resume.patch

Harald Welte laforge at openmoko.org
Wed May 23 02:50:52 CEST 2007

On Wed, May 23, 2007 at 02:35:46AM +0200, Harald Welte wrote:
> The correct solution to this problem thus is: Put the GPG12..15
> initialization in a s3c2410 specific section (runtime, not compile
> time).

Hm, it seems like the s3c24xx platform code provides no function to
determine at runtime whether we're running on a 2410 or 2440.

Ben: Is this intentional?

One possible implementation would follow the analogous approach of
s3cmci, i.e. use the platform_device name (s3c2410-ts vs. s3c2440-ts) to
differentiate, and have s3c2410-ts register two platform drivers.

However, I'm not sure if this is really more elegant than something as
simple as a hypothetical "if (get_s3c24xx_soc_type() == S3C2410)" .

Ben, what do you think?
- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
Software for the world's first truly open Free Software mobile phone

More information about the openmoko-kernel mailing list