[PATCH] GPS power management for GTA02

Harald Welte laforge at openmoko.org
Tue Oct 9 16:16:35 CEST 2007

On Tue, Oct 09, 2007 at 02:51:18PM +0800, Jim Huang wrote:
> gta01-pm-gps is not working under GTA02, and kernel dumps the following
> messages:
>   gta01-pm-gps.0: Unknown GTA01 Revision 0x320, GPS PM features not
> available!!!
>   gta01-pm-gps: probe of gta01-pm-gps.0 failed with error -1

yes, thanks for fixing this!

> This patch creates a working GPS PM driver reflecting the changes in PMU
> pcf50633 controls.

I wonder whether we should just merge this with gta01_pm_gps.c and
rename it to neo1973_pm_gps.c (and move it to arch/arm/mach-s3c2410, but
that's a different issue).

The code is very common, and the userspace application doesn't really
care what exact GPS chipset is underneath.  Yes, GTA01 has way more
fine-grained controls.  but the "echo 0/1" > power_up could be made
working on both GTA01 and GTA02.

What do you think, jserv?
- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
Software for the world's first truly open Free Software mobile phone

More information about the openmoko-kernel mailing list