[PATCH] GPS power management for GTA02

Harald Welte laforge at openmoko.org
Tue Oct 9 17:15:39 CEST 2007

On Tue, Oct 09, 2007 at 10:39:14PM +0800, Jim Huang wrote:

> Harald Welte 提到:
> > On Tue, Oct 09, 2007 at 02:51:18PM +0800, Jim Huang wrote:
> >> This patch creates a working GPS PM driver reflecting the changes in PMU
> >> pcf50633 controls.
> > I wonder whether we should just merge this with gta01_pm_gps.c and
> > rename it to neo1973_pm_gps.c (and move it to arch/arm/mach-s3c2410, but
> > that's a different issue).
> hi Harald,
> I thought using gta01 as prefix is misleading, and so I renamed it.
> Yes, the naming with neo1973_ prefix is better and makes sense for both
> GTA01 and GTA02.

ok.  the prefix is from a time where we had no idea that gta02 would
exist and how it would look like.  please feel free to submit a patch
for the rename + gta02 integration.  please also rename the platform
device (gta01-pm-{gps,gsm,bt}), then.  

Please also investigate which kind of changes to userspace are required,
I guess neod or some other things will need to adopt to the new naming.

> > The code is very common, and the userspace application doesn't really
> > care what exact GPS chipset is underneath.  Yes, GTA01 has way more
> > fine-grained controls.  but the "echo 0/1" > power_up could be made
> > working on both GTA01 and GTA02.
> > 
> > What do you think, jserv?
> I agree.  Since user-space applications only care about the way to power
> on/off GPS device, we shall use the same naming and sysfs entry.  The
> consideration is similar to GSM modem, but the later involves in more
> conditions such as hardware configurations and pin assignments.

For GSM and bluetooth it should also change from gta01 to neo1973.

In general, I think everything that is sufficently similar should have a
common neo1973 name.  The vibrator, e.g. also needs to be renamed.

Everything that is device specific will keep gta01 / gta02 naming.

- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
Software for the world's first truly open Free Software mobile phone

More information about the openmoko-kernel mailing list