[patch 4/6] jbt6k74: Add QVGA support

Stefan Schmidt stefan at openmoko.org
Mon Oct 22 11:15:43 CEST 2007


On Mon, 2007-10-22 at 17:03, Werner Almesberger wrote:
> Harald Welte wrote:
> > that one won't work since it uses bit-wise or | rather than logical or ||

The last one is of course what I intended to do.

> In ANSI C, the value of a relational expression is 0 or 1, so this
> would actually work.

And that explains why it worked fine during my tests.

Thanks for spotting and fixing this.

> I wouldn't consider it good practice, though,
> for a number of reasons. Also, those extra parentheses are some
> ancient Pascalism ...

I must have this from somewhere else. Never programmed Pascal. :)

And even Scheme was out of date as I started studies. ;)

Stefan Schmidt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 241 bytes
Desc: Digital signature
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20071022/9b550783/attachment.pgp 

More information about the openmoko-kernel mailing list