[PATCH] Accessing GPIO GPB_XY and not losing the LED state

Werner Almesberger werner at openmoko.org
Thu Apr 10 00:52:41 CEST 2008

Holger Freyther wrote:
> So is the approach sane, implementation as well, comments?

I think that's the least evil way to fix this. Still touches code at
a lot of places :-(

One question: why change s3c2410_gpio_setpin to neo1973_gpb_set_pin,
and not something_setpin ? That seems to be a gratuituous confusion.

I'd also to suggest to do something like

	BUG_ON(base != S3C24XX_GPIO_BASE(pin));

in neo1973_gpb_set_pin.

By the way, the vibrator doesn't need shadowing.

>    - Fix the gsm reset handling: GTA01_GPIO_MODEM_RST != GTA02_GPIO_MODEM_RST

Ah, so we have a bug there as well. And it's a nasty one, because it
could start myths like "GSM firmware download only works from outside
the phone". Why hide it in this big change ? Make the slaying of each
bug a celebration, well deserving of having its own patch :-)

- Werner

More information about the openmoko-kernel mailing list