[PATCH 1/1] Add Minimal GSM flowcontrol functionality

Andy Green andy at openmoko.com
Fri Aug 8 13:15:50 CEST 2008

Hash: SHA1

Somebody in the thread at some point said:

| The above changes seem to be necessary to get the change
| committed to stable; we can work on putting back some of the
| missing functionality in later.

Thanks for the patch Mike but something bad seems to have happened to
the whitespace in your tree.  Did you change editor?  All of the tabs
have been replaced with spaces in the files you are working on.

I see you use Thunderbird (me too), I didn't notice it do such things
until now but maybe the problem was introduced there.

Your patches don't apply at all unless I run patch -l so it treats
spaced tabbing as identical to actual tabbing, then the Kernel style
compliant tabbing is replaced by spaces that don't pass checkpatch.pl.

It's unfortunate we trip over this because I want to take your patches
straight away.  Can you take a look your side and see if tabs are
present and the transport or I introduced this somehow?  I did not see
it on any other patches though.

| (As noted by the date below, this patch has been around
| and well tested by now -- it will apply to stable, with some
| noise about offsets while patching.)
| Date:   Fri Jul 4 13:53:46 2008 -0500

Just to be clear, today is the first time this patch has been submitted
to Openmoko.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list