[PATCH] always call resume dependencies

Andy Green andy at openmoko.com
Mon Aug 11 19:07:55 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

|    Ensure that a dependent resume handler is always executed,
|    even if the resume handler for driver upon which it is
|    dependent never suspends (and therefore never resumes either).
|    Also make sure that we do not end up with duplicate
|    dependencies registered, something that can happen if the
|    suspend is aborted due to driver failure or an early resume
|    (such as occurs when the GSM interrupts during suspend).

I see, looks like it's really needed.

I think there is a trick we can do to make it tidier, move

is_suspended

to be an attribute of

struct resume_dependency

so it is set and tested all inside struct resume_dependency code.  What
do you think?

Another aspect is I got rid of most resume_dependency stuff in 2.6.26 by
the device tree re-order, so I think this will come out in the wash
there anyway.

But thanks for the work and spotting it.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkigcesACgkQOjLpvpq7dMrDXACdFb6YeZ61wkNHLkiz8w+sIE6y
nwgAnjc6ZrbE5x45tsm7rxG2d9szsAtI
=L1gI
-----END PGP SIGNATURE-----




More information about the openmoko-kernel mailing list