[PATCH] always call resume dependencies

Mike (mwester) mwester at dls.net
Mon Aug 11 20:16:26 CEST 2008

Andy Green wrote:

> I think there is a trick we can do to make it tidier, move
> is_suspended
> to be an attribute of
> struct resume_dependency
> so it is set and tested all inside struct resume_dependency code.  What
> do you think?
> Another aspect is I got rid of most resume_dependency stuff in 2.6.26 by
> the device tree re-order, so I think this will come out in the wash
> there anyway.
> But thanks for the work and spotting it.
> - -Andy

Yep, is_suspended could be tucked into struct resume_dependency. I tried
that originally, but since that tended to make the resume-dependency
stuff even more difficult for me to read -- and I knew that you were
replacing this all in 2.6.26 anyway -- I left it as you see it now.

If you want to move it in there, or want me to do that and resend
patches, let me know -- otherwise since it'll soon be old history and
happily behind us, it may not be worth much effort for anyone to tidy
that up at this point.

Mike (mwester)

More information about the openmoko-kernel mailing list