[PATCH] interface for configuring freefall/wakeup interrupts for the accelerometers
andy at openmoko.com
Fri Aug 15 13:01:32 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| First: Unfortunately, the freerunner currently wakes up immediately on
| suspend when the accelerometer IRQ is selected as a wakeup source. I'm
| posting this for comments and if someone else wants to have a look at
| this problem.
| The patch should be safe to apply even though the sleep portion doesn't
| work - as long as it's configured it will not disturb anything.
Thanks, sent it on to stable. Looks like fun stuff to work on.
BTW ./scripts/checkpatch.pl is your friend... I added a patch on top to
clean them which I posted. It's worth eyeballing to see which style
bits you need to look out for.
I noticed the whitespace was mostly tabs on empty lines (I fixed these
directly in your patch), I dunno what editor you use but I can very
heartily recommend KDE's kate if you are minded to try something
different. It has several nice features like subwindowing but two of
them relevant here are to clean out trailing whitespace on lines you are
editing automatically, and to display hard 80 col limit line in the
window. These features just completely remove those kinds of style
violation without any real effort.
About the wake, I don't have time to study it right now but I would
guess the accel is either still generating "sample ready" interrupt
somehow at sleep time, or it has signalled one during suspend that
didn't get serviced yet (because interrupts are off maybe).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel