[PATCH] fix-usb-gadget-udc-not-provoking-curlim-action.patch

Balaji Rao balajirrao at openmoko.org
Mon Dec 1 13:20:01 CET 2008


On Mon, Dec 01, 2008 at 12:11:06PM +0000, Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Somebody in the thread at some point said:
>
> | @@ -557,8 +557,9 @@ static void gta02_charger_worker(struct
> work_struct *work)
> |  static void gta02_pmu_event_callback(struct pcf50633 *pcf, int irq)
> |  {
> |  	if (irq == PCF50633_IRQ_USBINS) {
> | -		schedule_delayed_work(&gta02_charger_work,
> | -				GTA02_CHARGER_CONFIGURE_TIMEOUT);
> | +		if (!gta02_usb_vbus_draw)
> | +			schedule_delayed_work(&gta02_charger_work,
> | +					GTA02_CHARGER_CONFIGURE_TIMEOUT);
>
> if (!gta02_usb_vbus_draw) looks a bit funny, does it work out OK?

Hmmm.. Sorry, I never tried it out!

Ya, doesn't look like it'll solve the problem of the worker being
scheduled two times. It doesn't create any trouble anyway.
So, I guess we can go with your original patch, but probably with the
worker scheduled immediately in vbus_draw.

 Sorry for the noise!

	- Balaji




More information about the openmoko-kernel mailing list