[PATCH] add-skip_filter-s3c2410_ts.patch

Andy Green andy at openmoko.com
Tue Dec 2 11:17:34 CET 2008

Hash: SHA1

Somebody in the thread at some point said:
| Skip filter for touchscreen values.
| Problem: The first and the last sample might be unreliable. We provide
| this filter as a separate function in order to keep the event_send_timer_f
| function simple. This filter:
| * Skips NHEAD points after IE_DOWN
| * Skips NTAIL points before IE_UP
| * Ignores a click if we have less than (NHEAD + NTAIL + 1) points
| Right now the filter is embedded in the driver. We have two #defines with
| the parameters SKIP_NHEAD and SKIP_NTAIL. I didn't store their values in
| struct skip_filter on purpose.

Thanks, sent it on stable-tracking.

I saw in another email you're cooking a filter chain filter and I wonder
if any of the various things lying around in s3c2410_ts.c now are in
fact generic resistive touchscreen issues that also could go in a filter
chain filter of their own or be integrated as an option in an existing one.

With a lot of firepower abstracted out into the filters it seems that
s3c2410_ts.c could maybe be a bit smaller and simpler since really only
s3c24xx specific stuff must go there.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list