S3C64XX: Correct the EINT IRQ type configuration

Ben Dooks ben-linux at fluff.org
Tue Dec 2 20:04:17 CET 2008


On Tue, Dec 02, 2008 at 07:01:02PM +0000, Ben Dooks wrote:
> From: Matt Hsu <matt_hsu at openmoko.org>
> 
> Select the correct EINT configuration register when configuring
> the external interrupt level/edge type.
> 
> Signed-off-by: Matt Hsu <matt_hsu at openmoko.org>
> [ben-linux at fluff.org: description improvement]
> Signed-off-by: Ben Dooks <ben-linux at fluff.org>

I've applied this patch to the S3C64XX branch, I'll be pushing a new
copy out later once I've finished sorting out any other problems that
I find.

> ---
>  arch/arm/plat-s3c64xx/irq-eint.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Index: linux.git/arch/arm/plat-s3c64xx/irq-eint.c
> ===================================================================
> --- linux.git.orig/arch/arm/plat-s3c64xx/irq-eint.c	2008-11-20 11:40:22.000000000 +0000
> +++ linux.git/arch/arm/plat-s3c64xx/irq-eint.c	2008-12-02 19:00:11.000000000 +0000
> @@ -82,7 +82,7 @@ static int s3c_irq_eint_set_type(unsigne
>  	if (offs > 27)
>  		return -EINVAL;
>  
> -	if (offs > 15)
> +	if (offs <= 15)
>  		reg = S3C64XX_EINT0CON0;
>  	else
>  		reg = S3C64XX_EINT0CON1;
> 
> -- 
> Ben (ben at fluff.org, http://www.fluff.org/)
> 
>   'a smiley only costs 4 bytes'
> 

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.




More information about the openmoko-kernel mailing list