Werner Almesberger werner at openmoko.org
Fri Feb 1 01:43:34 CET 2008

Andy Green wrote:
> This series of patches add a C-based FIQ ISR, associate it with timer 3
> and finally implement vibrator PWM that previously used timer 3 directly
> using the FIQ ISR and GPIO control of the output.

Cool shit !

Applied in revision 4004.

Two issues for later consideration:

- include/asm-arm/arch-s3c2410/irqs.h shouldn't contain device-specific
  changes (this is not a problem of the FIQ patch per se, but shows up
  here as well). To be tackled later.

- "struct _fiq_ipc" in include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h
  isn't really just the usual "internal use only" declaration, so it
  should probably be "struct _fiq_ipc". In general, I think we should
  try to keep the number of _xxx or (better) __xxx items low and
  perhaps try to limit them to cases where there's a related xxx.

- Werner

More information about the openmoko-kernel mailing list