[PATCH 1/1] clean-fiq.patch (was Re: [PATCH 0/3] FIQ)

Andy Green andy at openmoko.com
Fri Feb 1 10:51:36 CET 2008

Hash: SHA1

Somebody in the thread at some point said:

Hi Werner -

> - include/asm-arm/arch-s3c2410/irqs.h shouldn't contain device-specific
>   changes (this is not a problem of the FIQ patch per se, but shows up
>   here as well). To be tackled later.

I think maybe you misunderstood this -- the only edit in there

+/* offset for FIQ IRQ numbers - used by arm fiq.c */
+#define FIQ_START 0

is actually feeding the pre-existing ./arch/arm/kernel/fiq.c:

void enable_fiq(int fiq)
	enable_irq(fiq + FIQ_START);  <====

void disable_fiq(int fiq)
	disable_irq(fiq + FIQ_START);   <====

not any of my code.  It's fixing an oversight that this define, required
to use arm arch fiq.c code on that machine, is not in there already.  So
with this additional info I hope you agree this addition to that include
is totally correctamundo, although evidently busting it out into its own
patch would have been clearer.

> - "struct _fiq_ipc" in include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h
>   isn't really just the usual "internal use only" declaration, so it
>   should probably be "struct _fiq_ipc". In general, I think we should

I think you missed an edit on that line :-)

>   try to keep the number of _xxx or (better) __xxx items low and
>   perhaps try to limit them to cases where there's a related xxx.

Fair enough, with the attached patch I changed it to use fiq_ipc_t which
is the method used in plenty of other places in the kernel (and indeed I
really ought to have used in the first place).

- -Andy
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clean-fiq.patch
Type: text/x-patch
Size: 1596 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20080201/33e0e0c8/attachment.bin 

More information about the openmoko-kernel mailing list