[PATCH 1/1] clean-fiq.patch (was Re: [PATCH 0/3] FIQ)

Werner Almesberger werner at openmoko.org
Fri Feb 1 13:41:54 CET 2008

Andy Green wrote:
> I think maybe you misunderstood this -- the only edit in there

I guess I wasn't clear :) I spotted the GLAMO entires while looking
at your patch, that's why I put this there as a reminder, for further

>>   should probably be "struct _fiq_ipc". In general, I think we should
> I think you missed an edit on that line :-)

Ah yes :)

> Fair enough, with the attached patch I changed it to use fiq_ipc_t which
> is the method used in plenty of other places in the kernel

Ick. "struct foo_t" ain't right. There's a lot of it in the Atheros
code, but that's all. (And that one has special dispension for not
following any coding style right now, because we all know that it'll
eventually get torn to pieces by the sharks on linux-kernel anyway ;-)

"foo_t" is actually reserved by POSIX, so even the common practice of
mimicking the way how "standard" typedef'ed types are named is
questionable at best. (And clearly wrong in user space.)

So, how about just "struct fiq_ipc" ?

- Werner

More information about the openmoko-kernel mailing list