[PATCH 1/1 Try#2] clean-fiq.patch (was Re: [PATCH 0/3] FIQ)

Andy Green andy at openmoko.com
Fri Feb 1 14:07:34 CET 2008

Hash: SHA1

Somebody in the thread at some point said:
> Andy Green wrote:
>> I think maybe you misunderstood this -- the only edit in there
> I guess I wasn't clear :) I spotted the GLAMO entires while looking
> at your patch, that's why I put this there as a reminder, for further
> study.

Nope you weren't clear :-)  So my change to that file is fine all around.

>>>   should probably be "struct _fiq_ipc". In general, I think we should
>> I think you missed an edit on that line :-)
> Ah yes :)
>> Fair enough, with the attached patch I changed it to use fiq_ipc_t which
>> is the method used in plenty of other places in the kernel
> Ick. "struct foo_t" ain't right. There's a lot of it in the Atheros
> code, but that's all. (And that one has special dispension for not
> following any coding style right now, because we all know that it'll
> eventually get torn to pieces by the sharks on linux-kernel anyway ;-)

linux-wireless will get it first, and believe me they can be tough
cookies because they don't want to get blamed for handing crap to their

> "foo_t" is actually reserved by POSIX, so even the common practice of
> mimicking the way how "standard" typedef'ed types are named is
> questionable at best. (And clearly wrong in user space.)

Well I even grepped for it in the sources before suggesting it, just to
"make sure".  But in fact despite a ton of hits it isn't really used for
local struct names in there, just on structs inherited from userspace
includes :-/  Plenty of it around though, plenty of the _type convention
around too.

> So, how about just "struct fiq_ipc" ?

Huh... obvious.

- -Andy
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clean-fiq.patch
Type: text/x-patch
Size: 1554 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20080201/412e7190/attachment.bin 

More information about the openmoko-kernel mailing list