[PATCH Try#2] introduce-fiq-hdq.patch

Michael 'Mickey' Lauer mickey at openmoko.org
Wed Feb 13 10:13:49 CET 2008

On Wednesday 13 February 2008 10:01:42 Andy Green wrote:
> Somebody in the thread at some point said:
> >> There's one change that's problematic in the light of recent
> >> discussion:
> >>
> >> -MODULE_DESCRIPTION("FIC Neo1973 GTA02 HDQ driver");
> >> +MODULE_DESCRIPTION("Neo Freerunner HDQ driver");
> >>
> >> That's the "marketing name". In order to avoid getting burned again,
> >> this should be either GTA02 or maybe OpenMoko GTA02.
> >
> > I agree. Please lets stick with GTA02 in source code.
> Can you explain why?  For MODULE_DESCRIPTION?

For everything that's not user-visible. The machine database entry is:

1304  	FIC Neo1973v2  	neo1973_gta02  	Harald Welte  	- unknown -

Adding FreeRunner will make it more confusing. Most kernel code I've seen is 
using the actual device codenames, not the marketing names, since the latter 
are prone to change or even mislead.


More information about the openmoko-kernel mailing list