[PATCH Try#2] introduce-bq27000-battery-driver.patch

Andy Green andy at openmoko.com
Wed Feb 13 22:14:40 CET 2008

Hash: SHA1

Somebody in the thread at some point said:
> Andy Green wrote:
>> introduce-bq27000-battery-driver.patch
> Applied in revision 4054 (as bq27000-battery-driver.patch).
> This "Try#2" is identical to the first version. Please holler if this
> isn't correct.
> There was one small problem with the build dependencies: since
> arch/arm/mach-s3c2440/mach-gta02.c unconditionally references
> gta02hdq_*, we need to enable POWER_SUPPLY and GTA02_HDQ.
> Also, GTA02_HDQ ended up outside the "if ... endif" in
> arch/arm/mach-s3c2440/Kconfig

Going through upleveling this stuff now, it was correct that GTA02_HDQ
was outside of the if... endif.  I took care there is AFAIK no
dependency in the HDQ layer to POWER_SUPPLY, you could use it as a pure
protocol to anything.  Well there was no dependency until you introduced
it now because you knew better just by glancing at the Kconfig.

When we're in Taipei we all need to have a big sit down and figure out
how we are going to stop this mokopatch insanity (and get *everyone's*
contributions posted to this list before they go in svn -- ha did I say
svn?  That's on the agenda too).

- -Andy
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list