[PATCH Try #2] GTA-02 U-Boot Splash working

Andy Green andy at openmoko.com
Mon Jan 21 16:15:28 CET 2008

Hash: SHA1

Somebody in the thread at some point said:
> Andy Green wrote:
>> GTA-02 U-Boot Splash is working here now.
> Great, thanks ! A few change requests:
> - board/neo1973/common/jbt6k74.c and others:
>   The  #if defined(CONFIG_ARCH_...)  chains are ugly. With r3897 I've
>   checked in a change that introduces a macro CONFIG_GTA02_REVISION with
>   the GTA02 revision number.
>   So you can do things like  #if CONFIG_GTA02_REVISION >=2  or
>   Your patch has a number of these hard to maintain old-style chains.

OK - I was just using what the rest of the code used... but this new way
you just introduced is better.

> - board/neo1973/common/jbt6k74.c:
>   "GTA-02" should be "GTA02"


> - board/neo1973/common/jbt6k74.c:
>   Why the removal of blank lines around "get LCM out of reset" ?
>   Seems to make things harder to read.

The linux-wireless list people hated vertical justification of any sort,
so I tried to adapt to their style.  I use an editor (kate) with syntax
highlight, it makes the comment touching code vertically still very
clear.  But I can see it will help to have a blank line on top.

> - drivers/video/smedia3362.c:
>   Various functions have the opening curly brace at the same line as
>   the argument list. E.g.,  void not_k_r_style(void) {


> - drivers/video/smedia3362.c:
>   There should be at least one blank line between functions. (And,
>   extrapolating, also between structs, e.g., u16a_gen_init_0x0000.)


> - drivers/video/smedia3362.c:
>   There should be a blank line after local variable "bp" in
>   glamo_core_init.


I also fixed some overlength lines.

Thanks for your comments.

If this doesn't apply nicely, let me know.

- -Andy
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot-framebuffer-lcm-splash.patch
Type: text/x-patch
Size: 19587 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20080121/e3e06632/attachment.bin 

More information about the openmoko-kernel mailing list