GTA01 shared UART vs. flow control (bug #788)
balrogg at gmail.com
Tue Jan 22 17:37:42 CET 2008
On 22/01/2008, Mike Westerhof <mwester at dls.net> wrote:
> On Tue 22/01/08 3:50 AM , Werner Almesberger werner at openmoko.org sent:
> > In the bugzilla thread, two patches have been submitted that try
> > to solve 2). One is fairly straightforward but misses the case
> > where flow control is enabled with GSM_EN set to the console. The
> > other one handles this case, but is complex and intrusive.
> As we embark on this discussion, can somone please define "intrusive" for me?
One simple definition is intrusive is when the string "neo" or "gta"
appers in the file drivers/serial/s3c2410.c - this should never
happen, it's not only intrusive but also incorrect. However I agree
with Andy that it's ok to merge it locally and have a sane behaviour
on our device.
More information about the openmoko-kernel