[PATCH] pcf50606: Fix wrong indexing in show_chgstate

Werner Almesberger werner at openmoko.org
Fri Jan 25 15:28:21 CET 2008


Andy Green wrote:
> It's wasting like 80+ bytes like that in the sparsely populated array of
> pointers to names.

Because of the same problem, we still have a wastage of about 4MB in
the GTA01 SD/MMC driver, so who cares about 80 bytes ? ;-)

I think I've missed your answers to my questions about the SD/MMC
voltage calculation. Is there a reason why, in your patch, the
sequence of values seems to be 100mV too low in general, and have a
discontinuity at the upper end ?

If the algorithm you have there is good, we can share it with GTA01
as well, nicely solving the above problem.

- Werner




More information about the openmoko-kernel mailing list