[PATCH 0/2] Charger monster taming

Holger Freyther zecke at openmoko.org
Tue Jul 22 18:34:17 CEST 2008

On Tuesday 22 July 2008 13:15:07 Andy Green wrote:
> These patches try to do something about the random non-charging
> behaviour getting reported, along with some incorrect behaviours
> of the charging trigger stuff Holger worked on.

cool. I have some minor comments and one question.

pcf50633_usb_curlim_set gets called from gta02 code in return to a usb plug 
action? So we enable charging when we know that a USB cable is inserted and 
can take the power we want, otherwise go to idle? Sounds sane.

minor comments:
	- I think we call the callbacks twice now. Once in set_cur_limit once in the 
enable charging..
	- To increase readability of the patch you might want to do the pdata change 
as a separate patch?

anyway thanks for tackling this, specially people will love the bq27000 


More information about the openmoko-kernel mailing list