[PATCH 2/2] fix-pcf50633-only-do-platform-callback-once-per-event.patch

Holger Freyther zecke at openmoko.org
Tue Jul 22 22:31:39 CEST 2008


On Tuesday 22 July 2008 21:30:08 Andy Green wrote:
> Reported-by: Holger Freyther <zecke at openmoko.org>
>
> We harmlessly repeated PMU platform callbacks about charging state twice.
> Clean it up and leave it to pcf50633_charge_enable() to report once.
>
> Also tidies the sequencing so we set current limit before we enable
> charger now.

Looks good. The last bits in this function and I'm too tired to read Figure 39 
tonight.


        /* clear batfull */
        reg_set_bit_mask(pcf, PCF50633_REG_MBCC1,
                                PCF50633_MBCC1_AUTORES,
                                0);
        reg_set_bit_mask(pcf, PCF50633_REG_MBCC1,
                                PCF50633_MBCC1_RESUME,
                                PCF50633_MBCC1_RESUME);
        reg_set_bit_mask(pcf, PCF50633_REG_MBCC1,
                                PCF50633_MBCC1_AUTORES,
                                PCF50633_MBCC1_AUTORES);

From the datasheet I know that resume has no effect when autores=1. Is that a 
trick to have an effect? It looks from the reports that charging stops and 
doesn't restart that we didn't have autoresume on (wildly guessing without 
knowing the MBC at all...)?



z.




More information about the openmoko-kernel mailing list