[PATCH 1/2] Janitor to make checkpatch.pl happy

Holger Freyther zecke at openmoko.org
Tue Jun 3 11:24:37 CEST 2008


From 347f37818a3c55084cf5d778e774c7c8da21aa65 Mon Sep 17 00:00:00 2001
From: Holger Freyther <zecke at openmoko.org>
Date: Thu, 29 May 2008 12:27:36 +0200
Subject: [PATCH] [janitor] Make checkpatch happy on the header files

---
 drivers/i2c/chips/pcf50633.c |    6 +++---
 include/linux/pcf50606.h     |    2 +-
 include/linux/pcf50633.h     |    6 +++---
 include/linux/pcf506xx.h     |    2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/i2c/chips/pcf50633.c b/drivers/i2c/chips/pcf50633.c
index ce476a4..9333603 100644
--- a/drivers/i2c/chips/pcf50633.c
+++ b/drivers/i2c/chips/pcf50633.c
@@ -157,7 +157,7 @@ struct pcf50633_data {
 };
 
 struct pcf50633_event_handler_data {
-	pmu_cb *handler;
+	pmu_cb handler;
 	void *data;
 	struct list_head entry;
 };
@@ -487,7 +487,7 @@ static void pcf50633_report_event(struct pcf50633_data 
*pcf, unsigned int featur
 	}
 }
 
-void pcf50633_add_event_handler(struct pcf50633_data *pcf, pmu_cb *handler, 
void *token)
+void pcf50633_add_event_handler(struct pcf50633_data *pcf, pmu_cb handler, 
void *token)
 {
 	struct pcf50633_event_handler_data *data;
 
@@ -502,7 +502,7 @@ void pcf50633_add_event_handler(struct pcf50633_data *pcf, 
pmu_cb *handler, void
 }
 EXPORT_SYMBOL_GPL(pcf50633_add_event_handler);
 
-void pcf50633_remove_event_handler(struct pcf50633_data *pcf, pmu_cb 
*_handler)
+void pcf50633_remove_event_handler(struct pcf50633_data *pcf, pmu_cb 
_handler)
 {
 	struct list_head *element;
 
diff --git a/include/linux/pcf50606.h b/include/linux/pcf50606.h
index 167328f..b17d35b 100644
--- a/include/linux/pcf50606.h
+++ b/include/linux/pcf50606.h
@@ -85,7 +85,7 @@ struct pcf50606_platform_data {
 	struct {
 		u_int8_t mbcc3; /* charger voltage / current */
 	} charger;
-	pmu_cb *cb;
+	pmu_cb cb;
 };
 
 #endif
diff --git a/include/linux/pcf50633.h b/include/linux/pcf50633.h
index c35a18e..9d4b0c6 100644
--- a/include/linux/pcf50633.h
+++ b/include/linux/pcf50633.h
@@ -125,10 +125,10 @@ extern int
 pcf50633_report_resumers(struct pcf50633_data *pcf, char *buf);
 
 extern void
-pcf50633_add_event_handler(struct pcf50633_data *pcf, pmu_cb* cb, void 
*data);
+pcf50633_add_event_handler(struct pcf50633_data *pcf, pmu_cb cb, void *data);
 
 extern void
-pcf50633_remove_event_handler(struct pcf50633_data *pcf, pmu_cb* cbr);
+pcf50633_remove_event_handler(struct pcf50633_data *pcf, pmu_cb cbr);
 
 
 #define PCF50633_FEAT_EXTON	0x00000001	/* not yet supported */
@@ -160,7 +160,7 @@ struct pcf50633_platform_data {
 	struct {
 		u_int8_t mbcc3; /* charger voltage / current */
 	} charger;
-	pmu_cb *cb;
+	pmu_cb cb;
 
 	/* post-resume backlight bringup */
 	int defer_resume_backlight;
diff --git a/include/linux/pcf506xx.h b/include/linux/pcf506xx.h
index d31bd14..c467c2d 100644
--- a/include/linux/pcf506xx.h
+++ b/include/linux/pcf506xx.h
@@ -24,7 +24,7 @@ enum pmu_event {
 	__NUM_PMU_EVTS
 };
 
-typedef int pmu_cb(struct device *dev, unsigned int feature,
+typedef int (*pmu_cb)(struct device *dev, unsigned int feature,
 		   enum pmu_event event, void *data);
 
 
-- 
1.5.4.3





More information about the openmoko-kernel mailing list