[PATCH 0/3] PMU and Battery interaction in regard to kobject uevent
werner at openmoko.org
Thu Jun 5 01:05:16 CEST 2008
Holger Freyther wrote:
> here we go... comments, criticism, gifts welcome
Hmm, can't say I'm bursting with joy, but at least this looks as clean
as it can get, given the circumstances.
Let me explain my misgivings:
- the PMU callback (not your fault, I know) is questionable to me.
This seems to be just the sort of thing that ought to be decided
in user space. Besides, I think that the logic it implements is
actually incorrect in GTA02. (Still need to prove that, though.)
- callbacks from one driver into another one always bear a risk of
causing nasty problems when more locking gets added for some
I know that there are much worse offenders, e.g., I2C, but still.
More information about the openmoko-kernel