[PATCH 0/9] various mainly pcf50633 resume improvements

Andy Green andy at openmoko.com
Fri Jun 13 23:16:05 CEST 2008

The following series gives me 240ms resume performance to video and
userspace up; resume feels very snappy indeed now.

I didn't like the need to hold LCM in reset during suspend so I
changed it to leave LCM powered in deep sleep mode.

It also fixes a resume order dependency issue with glamo mci wanting
to set power state of SD Card and therefore needing pcf50633 up.

pcf50633 interrupt workqueue is made to enforce resume state before
it is willing to stop deferring, the weird bugs around this went away
with a timeout on the glamo mci stuff above and subsequent fixing of it.

Individual I2C transactions in pcf50633 get wholesale moved to
single bulk autoincrenment transactions, the code is WAY simpler
after this is done to RTC as well and it provides major wins in
speed during suspend / resume.

Current limit notifications from USB stack got migrated into pcf50633
where they belonged in the first place, and made robust against coming
in during resume at bad times.

There is still at least one serious issue hiding in suspend / resume
racing -- I can kill resume stone dead by just adding an mdelay() in
Glamo suspend code, it should have zero effect.

So it's very interesting to hear any results from anyone else trying
these patches (which are on andy branch now).


Andy Green (9):

 arch/arm/mach-s3c2440/mach-gta02.c |   64 +++---
 drivers/i2c/chips/pcf50633.c       |  417 +++++++++++++++++++++++++-----------
 drivers/mfd/glamo/glamo-core.c     |    8 +
 drivers/mfd/glamo/glamo-core.h     |    3 
 drivers/mfd/glamo/glamo-mci.c      |   11 +
 drivers/video/display/jbt6k74.c    |   24 --
 include/linux/glamofb.h            |    2 
 include/linux/pcf50633.h           |    5 
 remote_install_sdcard              |   20 ++
 9 files changed, 381 insertions(+), 173 deletions(-)
 create mode 100755 remote_install_sdcard

More information about the openmoko-kernel mailing list